Updated build scripts to use auto-discovery #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maurei The failing AppVeyor builds puzzles me. Thoughts? |
added 2 commits
February 13, 2020 18:33
The problem: NoEntityFrameworkTests project has a reference to UnitTests project, which has a reference to JsonApiDotNetCoreExampleTests project, which has a reference to JsonApiDotNetCoreExample project. The last one contains an appsettings.json file with connection string to JsonApiDotNetCoreExample database. So when building, this file may end up in the output directory of NoEntityFrameworkTests project, overwriting the appsettings.json (containing the connection string to JsonApiDotNetCoreNoEFCoreExample database) from NoEntityFrameworkExample project. Next, if the NoEntityFrameworkTests testset runs first, it populates the JsonApiDotNetCoreExample database from models intended for the JsonApiDotNetCoreNoEFCoreExample database. And this causes subsequent test projects to fail.
|
Looks like you've figured it out. Let me know if this is the final state of the PR |
maurei
approved these changes
Feb 13, 2020
|
I haven't been able to find the root cause of the failures (which worries me), but running the tests in a fixed order (workaround) seems to work. So this is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures all projects in the solution are built in release mode and all unit tests in all projects in the solution are run.
Also removed outdated/broken additional solution files.